Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add tagged VLAN from other site on multiple port edit #11619

Closed
marinus81 opened this issue Jan 30, 2023 · 4 comments · Fixed by #12659
Closed

Cannot add tagged VLAN from other site on multiple port edit #11619

marinus81 opened this issue Jan 30, 2023 · 4 comments · Fixed by #12659
Assignees
@dhenschen
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@marinus81
Copy link

NetBox version

v3.4.2

Python version

3.8

Steps to Reproduce

I have come across an issue adding VLANs to an interface if I arrive at the interfrace configuration page from the DEVICES -> Device Components -> Interfaces page, and try to edit multiple interface from the list (on the same device). I can only add VLANs as tagged VLANs if they are allocated to the same Site as the Device. This issue does not exist if I go to the Device Page and from there the Interfaces sub-page.

  1. Create Site "SITE_TEST"
  2. Create vlan 10 in Site "SITE_TEST"
  3. Create vlan 20 in no Site
  4. Create a device "DEV_TEST" in Site "SITE_TEST" with at leasttwo interfaces
  5. Navigate to DEVICES -> Device Components -> Interfaces
  6. Filter for all interfaces from device "DEV_TEST"
  7. OK: Edit single interface -> 802.1Q Switching Mode: Tagged -> Tagged VLANs includes VLAN 10 and 20 -> as expected
  8. NOK: Edit multiple interfaces -> 802.1Q Switching Mode: Tagged -> Tagged VLANs includes ony VLAN 10 -> not expected

Expected Behavior

Same behavior between "Device -> Interfaces sub-page" and "DEVICES -> Device Components -> Interfaces + filter for a device"

Observed Behavior

"Device -> Interfaces sub-page" - I can add VLANs from same site or VLANs without Site assigned
"DEVICES -> Device Components -> Interfaces + filter for a device" - I can only add VLANs from same Site as Device
@marinus81 marinus81 added the type: bug A confirmed report of unexpected behavior in the application label Jan 30, 2023
@HolySephi

This comment was marked as off-topic.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label May 2, 2023
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed pending closure Requires immediate attention to avoid being closed for inactivity labels May 3, 2023
@dhenschen
Copy link
Contributor

I'm interested in taking ownership of this issue.

I've ran into this before while using NetBox and would like to see it fixed.

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 8, 2023
@dhenschen dhenschen mentioned this issue May 16, 2023
Closed
@dhenschen
Copy link
Contributor

I opened #12622 to track a related bug that impacts the creation and import of prefixes in IPAM. The fix for that issue is different than what will be required for this issue.

dhenschen added a commit to dhenschen/netbox that referenced this issue May 18, 2023
@dhenschen
Closes netbox-community#11619: Allow VLANs without during multi-port …
1fab6e6 
…edit

This commit allows users to be able to select VLANs without a site assignment
during miltiple port edits under Devices > DEVICE COMPONENTS > Interfaces.

Prior to this commit, only VLANs that were assigned the same site as the device
were available for selection.

This change Closes netbox-community#11619
dhenschen added a commit to dhenschen/netbox that referenced this issue May 19, 2023
@dhenschen
Closes netbox-community#11619: Allow VLANs without during multi-port …
36af1e1 
…edit

This commit allows users to be able to select VLANs without a site assignment
during miltiple port edits under Devices > DEVICE COMPONENTS > Interfaces.

Prior to this commit, only VLANs that were assigned the same site as the device
were available for selection.
dhenschen added a commit to dhenschen/netbox that referenced this issue May 19, 2023
@dhenschen
Closes netbox-community#11619: Allow VLANs without during multi-port …
e074191 
…edit

This commit allows users to be able to select VLANs without a site assignment
during bulk interfaces edits under Devices > DEVICE COMPONENTS > Interfaces.

Prior to this commit, only VLANs that were assigned the same site as the device
were available for selection.
dhenschen added a commit to dhenschen/netbox that referenced this issue May 19, 2023
@dhenschen
Closes netbox-community#11619: Allow VLANs without a site during mult…
9a159db 
…i-port edits

This commit allows users to be able to select VLANs without a site assignment
during bulk interfaces edits under Devices > DEVICE COMPONENTS > Interfaces.

Prior to this commit, only VLANs that were assigned the same site as the device
were available for selection.
@dhenschen dhenschen mentioned this issue May 19, 2023
Merged
jeremystretch added a commit that referenced this issue May 22, 2023
@dhenschen @jeremystretch
Closes #11619: Include VLANs with a null site in query during bulk in…
078893e 
…terface edit for Devices > DEVICE COMPONENTS > Interfaces (#12659)

* Closes #11619: Allow VLANs without a site during multi-port edits

This commit allows users to be able to select VLANs without a site assignment
during bulk interfaces edits under Devices > DEVICE COMPONENTS > Interfaces.

Prior to this commit, only VLANs that were assigned the same site as the device
were available for selection.

* Replace 'null' with FILTERS_NULL_CHOICE_VALUE constant

---------

Co-authored-by: jeremystretch <[email protected]>
@jeremystretch jeremystretch mentioned this issue May 22, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhenschen dhenschen

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
5 participants
@HolySephi @abhi1693 @dhenschen @jeremystretch @marinus81