Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4-beta1: Plugin menu label consisting of multiple words breaks unfolding menu #10984

Closed
peteeckel opened this issue Nov 19, 2022 · 0 comments
Closed
Assignees
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@peteeckel
Copy link
Contributor

peteeckel commented Nov 19, 2022

NetBox version

v3.4-beta1

Python version

3.8

Steps to Reproduce

  1. Create a plugin menu with more than two words, separated by a blank, as its label:
menu = PluginMenu(
    label="NetBox DNS",
    groups=(
        ("DNS Configuration", (view_menu_item,
                               nameserver_menu_item,
                               zone_menu_item,
                               record_menu_item,
                               managed_record_menu_item)),
    ),
    icon_class='mdi mdi-dns',
)
  1. After restarting NetBox, open the GUI at the main menu
  2. Click on the plugin menu name

Expected Behavior

The plugin menu opens, showing the menu items.

Observed Behavior

The plugin menu is displayed in the side bar, but does not unfold when clicking on it. The tooltip for the menu shows "Go to #menuNetBox%20DNS on this page".

When you navigate to a page belonging to the plugin by entering the URL (e.g. plugins/netbox-dns/records/), the menu is displayed correctly and unfolded.

Screenshot 2022-11-19 at 18 22 42

However, after clicking on it to collapse it it is unresponsive again and the problem is the same as above. Reloading the page reopens the menu as long as one does not navigate away from the plugin specific page.

It can be worked around by removing the blank from the menu label (e.g. NetBoxDNS). Without a blank in the name everything works as expected.

@peteeckel peteeckel added the type: bug A confirmed report of unexpected behavior in the application label Nov 19, 2022
@peteeckel peteeckel changed the title 3.4-beta1: Plugin menu label consisting of multiple words does not unfold after collapsed 3.4-beta1: Plugin menu label consisting of multiple words does not unfold when collapsed Nov 19, 2022
@peteeckel peteeckel changed the title 3.4-beta1: Plugin menu label consisting of multiple words does not unfold when collapsed 3.4-beta1: Plugin menu label consisting of multiple words breaks unfolding menu Nov 19, 2022
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Nov 19, 2022
@jeremystretch jeremystretch self-assigned this Nov 21, 2022
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Nov 21, 2022
jeremystretch added a commit that referenced this issue Nov 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants