Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace import_object() with Django's import_string() #10699

Closed
jeremystretch opened this issue Oct 19, 2022 · 0 comments
Closed

Replace import_object() with Django's import_string() #10699

jeremystretch opened this issue Oct 19, 2022 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v3.4

Comments

@jeremystretch
Copy link
Member

Proposed Changes

extras.plugins.utils defines a custom import_object() function, which is used to dynamically import modules specified by a string. This can be removed and replaced with Django's own import_string() function.

Although this is not a documented part of the plugins API, we should bind this to a minor release to avoid any surprises for plugin authors who opted to use it.

Justification

Eliminates unnecessary code and leverages a Django utility.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Oct 19, 2022
@jeremystretch jeremystretch added this to the v3.4 milestone Oct 19, 2022
@jeremystretch jeremystretch added type: deprecation Removal of existing functionality or behavior and removed type: housekeeping Changes to the application which do not directly impact the end user labels Oct 19, 2022
@jeremystretch jeremystretch self-assigned this Oct 19, 2022
jeremystretch added a commit that referenced this issue Oct 19, 2022
@jeremystretch
Closes #10699: Remove custom import_object() function
85a4b1f
@jeremystretch jeremystretch mentioned this issue Dec 14, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v3.4
Development

No branches or pull requests
1 participant
@jeremystretch