Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Edit for Newly Imported Items #10242

Closed
NavyWings opened this issue Sep 1, 2022 · 5 comments
Closed

Bulk Edit for Newly Imported Items #10242

NavyWings opened this issue Sep 1, 2022 · 5 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@NavyWings
Copy link

NetBox version

v3.2.2

Feature type

Change to existing functionality

Proposed functionality

After bulk importing of items (Devices in this particular example), the "Import Completed" page is displayed with a list of items imported. I propose adding a "Bulk Edit" option similar to most lists of objects in Netbox.

image

Use case

Imports may or may not require corrections following import. After import, there may not be a unique way of selecting the new objects that were imported if edits need to be made. By having a bulk edit feature available on the "Import Completed" page, it would easily allow edits to be made to the newly imported objects.

Database changes

Likely no new DB changes

External dependencies

None

@NavyWings NavyWings added the type: feature Introduction of new functionality to the application label Sep 1, 2022
@jeremystretch
Copy link
Member

jeremystretch commented Sep 1, 2022

I think the ideal approach here would be to ditch the static rendering of imported objects, and replace it with a redirect to the normal objects list that's been filtered to display only the newly-imported items. (This would automatically include bulk edit & delete functions.) I'm just not sure how to best do that short of appending a ton of ?id=101&id=102&id=103 cruft. Will have to think about this some more.

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Sep 1, 2022
@DanSheps
Copy link
Member

DanSheps commented Sep 6, 2022

@jeremystretch Any chance you could do something with the changelog id?

@jeremystretch
Copy link
Member

jeremystretch commented Sep 6, 2022

@DanSheps Possibly, but it probably wouldn't be very efficient. We'd probably also be risking a race condition since the creation of change records is queued. This isn't true today, but could be in the future.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Nov 6, 2022
@jeremystretch jeremystretch added needs milestone Awaiting prioritization for inclusion with a future NetBox release and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Nov 7, 2022
@jeremystretch
Copy link
Member

I've opened #11494 to test out Dan's idea above. Marking this as blocked for now, but the approach seems very promising.

@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Jan 13, 2023
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: blocked Another issue or external requirement is preventing implementation labels Mar 16, 2023
@jeremystretch jeremystretch self-assigned this Mar 16, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Mar 16, 2023
@jeremystretch jeremystretch added this to the v3.5 milestone Mar 16, 2023
jeremystretch added a commit that referenced this issue Mar 17, 2023
…12001)

* Redirect user to filtered objects list after bulk import

* Remove obsolete table attribute from bulk import views
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants