Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slug for L2VPN has no unique constraint #10070

Closed
v0tti opened this issue Aug 19, 2022 · 2 comments · Fixed by #10119
Closed

Slug for L2VPN has no unique constraint #10070

v0tti opened this issue Aug 19, 2022 · 2 comments · Fixed by #10119
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@v0tti
Copy link
Contributor

v0tti commented Aug 19, 2022

NetBox version

v3.3.0

Python version

3.9

Steps to Reproduce

  1. Create a L2VPN with name Test and slug test
  2. Create a L2VPN with name Test2 and slug test

Expected Behavior

I expect a warning to be displayed when trying to create the second L2VPN with the same slug as the one before. The slug should be an unique attribute. It is unique for other models i.e. Tenants.

Observed Behavior

The second L2VPN is created without a warning or an error. Two L2VPN with the same slug exist at the same time.
@v0tti v0tti added the type: bug A confirmed report of unexpected behavior in the application label Aug 19, 2022
@jeremystretch
Copy link
Member

@DanSheps is this intentional or a bug?

@DanSheps
Copy link
Member

This would be a bug. Slug should have been unique.

@DanSheps DanSheps added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Aug 19, 2022
@arthanson arthanson self-assigned this Aug 22, 2022
arthanson added a commit to arthanson/netbox that referenced this issue Aug 22, 2022
@arthanson
fixes for netbox-community#10070 make l2vpn slug unique
f5dbc87
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Aug 22, 2022
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Aug 22, 2022
@arthanson arthanson mentioned this issue Aug 23, 2022
Merged
jeremystretch added a commit that referenced this issue Aug 24, 2022
@arthanson @jeremystretch
fixes for #10070 make l2vpn slug unique (#10119)
4132027 
Co-authored-by: jeremystretch <[email protected]>
jeremystretch added a commit that referenced this issue Aug 24, 2022
@jeremystretch
Changelog for #10070
6c686af
@jeremystretch jeremystretch mentioned this issue Aug 25, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes for #10070 make l2vpn slug unique arthanson/netbox
4 participants
@arthanson @v0tti @DanSheps @jeremystretch