Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Management IPv4 Address shows erroneous text "(NAT:)" when IP has no NAT associations #10055

Closed
ZPrimed opened this issue Aug 17, 2022 · 1 comment · Fixed by #10065
Closed

Device Management IPv4 Address shows erroneous text "(NAT:)" when IP has no NAT associations #10055

ZPrimed opened this issue Aug 17, 2022 · 1 comment · Fixed by #10065
Assignees
@atownson
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@ZPrimed
Copy link

ZPrimed commented Aug 17, 2022

NetBox version

v3.3.0

Python version

3.8

Steps to Reproduce

This is a minor / Display Bug

I am seeing this on all Device instances in my installation (which was upgraded from 3.2.8 to 3.3.0).
It is also reproducible on a newly-created Device / Interface / IP combo.

  1. Create a Device with at least one Interface
  2. Set (or create) an IP Address on that Interface, and check the box to make it the "Primary IP for this device" (i.e. management address)
  3. View the Device's overview page, note that in the "Management" box there is the text "(NAT:)" after the IP address

Screenshot from my own installation with a pre-existing device:
image

Expected Behavior

Would not expect to see any information about NAT when the IP address has no NAT relationships defined. (Suspect this is related to the change in the nat_outside relation to return zero or more IPs instead of the past "None or one"?)

Observed Behavior

UI displays spurious "(NAT:)" text when it shouldn't
@ZPrimed ZPrimed added the type: bug A confirmed report of unexpected behavior in the application label Aug 17, 2022
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Aug 18, 2022
@atownson
Copy link
Contributor

I can work on this.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 18, 2022
atownson added a commit to atownson/netbox that referenced this issue Aug 18, 2022
@atownson
netbox-community#10055 - Add loop for NAT Outside
c811eb0
atownson added a commit to atownson/netbox that referenced this issue Aug 18, 2022
@atownson
netbox-community#10055 - Add loop for NAT Outside
a687aa1
atownson added a commit to atownson/netbox that referenced this issue Aug 18, 2022
@atownson
netbox-community#10055 - Add template for NAT Outside
3f40e15 
Fixes 'ipam.IPAddress.None' text
atownson added a commit to atownson/netbox that referenced this issue Aug 18, 2022
@atownson
netbox-community#10055 - Align NAT Outside with NAT Inside
0bdee1d
@atownson atownson mentioned this issue Aug 18, 2022
Closed
atownson added a commit to atownson/netbox that referenced this issue Aug 18, 2022
@atownson
netbox-community#10055: Added empty text
43ad8e8
@atownson atownson mentioned this issue Aug 18, 2022
Merged
jeremystretch added a commit that referenced this issue Aug 23, 2022
@jeremystretch
Merge pull request #10065 from atownson/issue_10055
7b41892 
Fixes #10055: NAT Outside evaluations and links
@jeremystretch jeremystretch mentioned this issue Aug 25, 2022
Merged
@hagbarddenstore hagbarddenstore mentioned this issue Oct 22, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atownson atownson

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
3 participants
@ZPrimed @jeremystretch @atownson