16136 remove Django Admin (#17619)

* 16136 remove Django Admin * 16136 fix plugin test * 16136 fix migrations * Revert "16136 fix migrations" This reverts commit 80296fa. * Remove obsolete admin module from dummy plugin * Remove obsolete admin site configuration * Remove unused import statement * Remove obsolete admin module * Misc cleanup --------- Co-authored-by: Jeremy Stretch <[email protected]>
netbox-community · Oct 16, 2024 · a320bda · a320bda
1 parent 82de559
commit a320bda
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 60 deletions.
diff --git a/docs/configuration/miscellaneous.md b/docs/configuration/miscellaneous.md
@@ -96,14 +96,6 @@ The maximum size (in bytes) of an incoming HTTP request (i.e. `GET` or `POST` da
 
 ---
 
-## DJANGO_ADMIN_ENABLED
-
-Default: False
-
-Setting this to True installs the `django.contrib.admin` app and enables the [Django admin UI](https://docs.djangoproject.com/en/5.0/ref/contrib/admin/). This may be necessary to support older plugins which do not integrate with the native NetBox interface.
-
----
-
 ## ENFORCE_GLOBAL_UNIQUE
 
 !!! tip "Dynamic Configuration Parameter"

diff --git a/netbox/netbox/admin.py b/netbox/netbox/admin.py
diff --git a/netbox/netbox/configuration_testing.py b/netbox/netbox/configuration_testing.py
@@ -39,8 +39,6 @@
 
 SECRET_KEY = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789'
 
-DJANGO_ADMIN_ENABLED = True
-
 DEFAULT_PERMISSIONS = {}
 
 LOGGING = {

diff --git a/netbox/netbox/plugins/urls.py b/netbox/netbox/plugins/urls.py
@@ -8,7 +8,6 @@
 
 from . import views
 
-# Initialize URL base, API, and admin URL patterns for plugins
 plugin_patterns = []
 plugin_api_patterns = [
     path('', views.PluginsAPIRootView.as_view(), name='api-root'),

diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
@@ -108,7 +108,6 @@
     'users.delete_token': ({'user': '$user'},),
 })
 DEVELOPER = getattr(configuration, 'DEVELOPER', False)
-DJANGO_ADMIN_ENABLED = getattr(configuration, 'DJANGO_ADMIN_ENABLED', False)
 DOCS_ROOT = getattr(configuration, 'DOCS_ROOT', os.path.join(os.path.dirname(BASE_DIR), 'docs'))
 EMAIL = getattr(configuration, 'EMAIL', {})
 EVENTS_PIPELINE = getattr(configuration, 'EVENTS_PIPELINE', (
@@ -371,7 +370,6 @@ def _setting(name, default=None):
 #
 
 INSTALLED_APPS = [
-    'django.contrib.admin',
     'django.contrib.auth',
     'django.contrib.contenttypes',
     'django.contrib.sessions',
@@ -409,8 +407,6 @@ def _setting(name, default=None):
 ]
 if not DEBUG:
     INSTALLED_APPS.remove('debug_toolbar')
-if not DJANGO_ADMIN_ENABLED:
-    INSTALLED_APPS.remove('django.contrib.admin')
 
 # Middleware
 MIDDLEWARE = [
@@ -547,7 +543,6 @@ def _setting(name, default=None):
 
 # All URLs starting with a string listed here are exempt from maintenance mode enforcement
 MAINTENANCE_EXEMPT_PATHS = (
-    f'/{BASE_PATH}admin/',
     f'/{BASE_PATH}extras/config-revisions/',  # Allow modifying the configuration
     LOGIN_URL,
     LOGIN_REDIRECT_URL,

diff --git a/netbox/netbox/tests/dummy_plugin/admin.py b/netbox/netbox/tests/dummy_plugin/admin.py
diff --git a/netbox/netbox/tests/test_plugins.py b/netbox/netbox/tests/test_plugins.py
@@ -36,12 +36,6 @@ def test_models(self):
         instance.delete()
         self.assertIsNone(instance.pk)
 
-    def test_admin(self):
-
-        # Test admin view URL resolution
-        url = reverse('admin:dummy_plugin_dummymodel_add')
-        self.assertEqual(url, '/admin/dummy_plugin/dummymodel/add/')
-
     @override_settings(LOGIN_REQUIRED=False)
     def test_views(self):
 

diff --git a/netbox/netbox/urls.py b/netbox/netbox/urls.py
@@ -77,11 +77,6 @@
     path('api/plugins/', include((plugin_api_patterns, 'plugins-api'))),
 ]
 
-# Django admin UI
-if settings.DJANGO_ADMIN_ENABLED:
-    from .admin import admin_site
-    _patterns.append(path('admin/', admin_site.urls))
-
 # django-debug-toolbar
 if settings.DEBUG:
     import debug_toolbar

diff --git a/netbox/templates/inc/user_menu.html b/netbox/templates/inc/user_menu.html
@@ -36,11 +36,6 @@
       </div>
     </a>
     <div class="dropdown-menu dropdown-menu-end dropdown-menu-arrow" {% htmx_boost %}>
-      {% if config.DJANGO_ADMIN_ENABLED and request.user.is_staff %}
-        <a class="dropdown-item" href="{% url 'admin:index' %}">
-          <i class="mdi mdi-cog"></i> {% trans "Django Admin" %}
-        </a>
-      {% endif %}
       <a href="{% url 'account:profile' %}" class="dropdown-item">
         <i class="mdi mdi-account"></i> {% trans "Profile" %}
       </a>

diff --git a/netbox/users/admin.py b/netbox/users/admin.py