Fixes #15961: Fix secret toggle button by avoiding duplicate event ha…

…ndler
netbox-community · May 6, 2024 · 4becede · 4becede
1 parent 4cc5079
commit 4becede
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 17 deletions.
diff --git a/netbox/project-static/dist/netbox.js b/netbox/project-static/dist/netbox.js
diff --git a/netbox/project-static/dist/netbox.js.map b/netbox/project-static/dist/netbox.js.map
diff --git a/netbox/project-static/src/buttons/secretToggle.ts b/netbox/project-static/src/buttons/secretToggle.ts
@@ -60,18 +60,17 @@ function handleSecretToggle(state: StateManager<SecretState>, button: HTMLButton
   toggleSecretButton(hidden, button);
 }
 
+function toggleCallback(event: MouseEvent) {
+  handleSecretToggle(secretState, event.currentTarget as HTMLButtonElement);
+}
+
 /**
  * Initialize secret toggle button.
  */
 export function initSecretToggle(): void {
   hideSecret();
   for (const button of getElements<HTMLButtonElement>('button.toggle-secret')) {
-    button.addEventListener(
-      'click',
-      event => {
-        handleSecretToggle(secretState, event.currentTarget as HTMLButtonElement);
-      },
-      false,
-    );
+    button.removeEventListener('click', toggleCallback);
+    button.addEventListener('click', toggleCallback);
   }
 }