Skip to content

Commit

Permalink
Closes #15100: Remove obsolete NullableCharField class
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremystretch committed Feb 9, 2024
1 parent d8c6dad commit 25723ae
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
1 change: 1 addition & 0 deletions docs/release-notes/version-4.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ The NetBox user interface has been completely refreshed and updated.
* [#14658](https://github.com/netbox-community/netbox/issues/14658) - Remove backward compatibility for importing `process_webhook()` (now `extras.webhooks.send_webhook()`)
* [#14740](https://github.com/netbox-community/netbox/issues/14740) - Remove the obsolete `BootstrapMixin` form mixin class
* [#15099](https://github.com/netbox-community/netbox/issues/15099) - Remove obsolete `device_role` and `device_role_id` filters for devices
* [#15100](https://github.com/netbox-community/netbox/issues/15100) - Remove obsolete `NullableCharField` class
16 changes: 0 additions & 16 deletions netbox/utilities/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,10 @@
'ColorField',
'CounterCacheField',
'NaturalOrderingField',
'NullableCharField',
'RestrictedGenericForeignKey',
)


# Deprecated: Retained only to ensure successful migration from early releases
# Use models.CharField(null=True) instead
# TODO: Remove in v4.0
class NullableCharField(models.CharField):
description = "Stores empty values as NULL rather than ''"

def to_python(self, value):
if isinstance(value, models.CharField):
return value
return value or ''

def get_prep_value(self, value):
return value or None


class ColorField(models.CharField):
default_validators = [ColorValidator]
description = "A hexadecimal RGB color code"
Expand Down

0 comments on commit 25723ae

Please sign in to comment.