Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more tests #965

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Added more tests #965

merged 3 commits into from
Mar 16, 2023

Conversation

tobiasge
Copy link
Member

Related Issue:

New Behavior

  • More tests

Contrast to Current Behavior

  • Didn't test the container start

Discussion: Benefits and Drawbacks

  • Should catch errors better

Changes to the Wiki

  • None

Proposed Release Note Entry

  • None

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge added the enhancement The issue describes an enhancement that we would like to implement in the future. label Mar 16, 2023
cimnine
cimnine approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool that you built this 🥰

@tobiasge tobiasge merged commit f2d070f into netbox-community:develop Mar 16, 2023
@tobiasge tobiasge deleted the more-tests branch March 16, 2023 20:44
@tobiasge tobiasge mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
enhancement The issue describes an enhancement that we would like to implement in the future.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine