Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #947: Rebuild search index when needed #948

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fixes #947: Rebuild search index when needed #948

merged 1 commit into from
Mar 14, 2023

Conversation

tobiasge
Copy link
Member

Related Issue: #947

New Behavior

  • Rebuilds search index on startup when models have changed

Contrast to Current Behavior

  • Global search is broken because search index entries are missing

Discussion: Benefits and Drawbacks

  • When we run this on startup users should not need to worry about the indexes.
  • But this makes the start a bit slower

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Enabled search index rebuilding on start

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge
Fixes netbox-community#947: Rebuild search index when needed
e60a746 
This rebuilds the search index when models where updated.
@tobiasge tobiasge requested a review from cimnine February 23, 2023 07:42
@tobiasge tobiasge enabled auto-merge February 23, 2023 09:35
@kkthxbye-code
Copy link

Any way we can get this out soon-ish?

cimnine
cimnine approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I approved this weeks ago 🙈

@tobiasge tobiasge merged commit ed309a1 into netbox-community:develop Mar 14, 2023
@tobiasge tobiasge mentioned this pull request Mar 15, 2023
Closed
@tobiasge tobiasge deleted the lazy-reindex-on-start branch March 15, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasge @kkthxbye-code @cimnine