Actually fix #471 and #931 #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This part must have been lost in the formatting commit because it was there when I tested the configuration. I think your branch is not up to date with develop. The commit tab show 5 commits to be merged when only one should be there. |
timrabl
force-pushed
the
fix-931
branch
2 times, most recently
from
0a12526 to
58799f8
Compare
add missing AUTH_LDAP_USER_SEARCH, removed while modifying.... revert AUTH_LDAP_USER_SEARCH variable that was accidentally removed in netbox-community#931 and change behaviour to requested features in netbox-community#471 remove duplicate AUTH_LDAP_USER_SEARCH variable now and fix this finally, hopefully
tobiasge
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
New Behavior
Same as in #931
Contrast to Current Behavior
Same as in #931, but reverts AUTH_LDAP_USER_SEARCH that was accidentally removed...
Discussion: Benefits and Drawbacks
Changes to the Wiki
Same as in #931
Proposed Release Note Entry
Same as in #931
Double Check
developbranch.