Fix syntax of docker compose commands #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.4.0
Docker compose's syntax changed as of Compose v2 (source: https://docs.docker.com/compose/reference/). Replaced references of "docker-compose" with "docker compose" to align with this change.
cimnine
approved these changes
Jan 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
New Behavior
Update commands in readme file to align with current docker compose syntax.
Contrast to Current Behavior
If a user were to copy/paste the existing compose file in the README file, the
docker-composecommands would fail. This syntax was changed in Compose v2 (source: https://docs.docker.com/compose/reference/)Discussion: Benefits and Drawbacks
This PR is a simple fix to adjust syntax, that's all. No drawbacks, no compatibility to consider.
Changes to the Wiki
This PR is to update the README.md itself.
Proposed Release Note Entry
Updated
composesyntax in README.md to current syntaxDouble Check
developbranch.