Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend docker.io to image URLs #910

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

sc68cal
Copy link
Contributor

@sc68cal sc68cal commented Dec 27, 2022

Related Issue: N/A

New Behavior

This is to make podman happy, since newer versions of podman have set short-name-mode to enforcing
https://github.com/containers/image/blob/main/docs/containers-registries.conf.5.md

Contrast to Current Behavior

Without this change, podman-compose fails to start up the containers

Discussion: Benefits and Drawbacks

I do not see any downsides to this change since it should also work correctly in docker-compose as well, by making
the image URLs more explicit rather than implicitly relying on docker.io

Changes to the Wiki

None required

Proposed Release Note Entry

Prepend docker.io to image URLs for all containers in the compose file

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@sc68cal
Copy link
Contributor Author

sc68cal commented Dec 27, 2022

This was tested with podman-compose and works correctly now. Prior to this change podman-compose would fail due to the issue with shortnames

This is to make podman happy, since newer versions of podman
have set short-name-mode to enforcing

https://github.com/containers/image/blob/main/docs/containers-registries.conf.5.md
@tobiasge tobiasge force-pushed the enforcing_shortname branch from e38c7b9 to 41d80d6 Compare January 10, 2023 13:10
@tobiasge
Copy link
Member

Please fill out the PR template and target the pull request to develop as described in the template.

@sc68cal sc68cal changed the base branch from release to develop January 10, 2023 15:11
@tobiasge tobiasge merged commit 350747c into netbox-community:develop Jan 28, 2023
@tobiasge tobiasge mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants