Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup scripts complete removal #893

Merged

Conversation

tobiasge
Copy link
Member

Related Issue: -

New Behavior

  • Removed startup warning for initializer scripts
  • Actually test the compose configuration

Contrast to Current Behavior

  • Old warnings was printed
  • No testing of complete setup

Discussion: Benefits and Drawbacks

  • None

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Improved the testing of our compose setup

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

.github/workflows/push.yml Show resolved Hide resolved
After the initializer scripts were removed, we didn't test the actual compose setup anymore. This adds new tests to run the database migrations.
@tobiasge tobiasge force-pushed the startup-scripts-complete-removal branch from 05cfb46 to aa33578 Compare November 30, 2022 09:54
@tobiasge tobiasge merged commit b720842 into netbox-community:develop Nov 30, 2022
@tobiasge tobiasge deleted the startup-scripts-complete-removal branch November 30, 2022 12:14
@tobiasge tobiasge mentioned this pull request Dec 15, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants