Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a volume for the caching Redis #852

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Define a volume for the caching Redis #852

merged 3 commits into from
Oct 6, 2022

Conversation

Delta1977
Copy link
Contributor

@Delta1977 Delta1977 commented Sep 23, 2022

Related Issue: #851

New Behavior

Prevent the creation of a temporary volume for the caching redis

Contrast to Current Behavior

Docker automatically creates a volume for /data, as the Container manifest of redis defines a volume.

Discussion: Benefits and Drawbacks

The benefit is that less unmanaged volumes are created and that the ones who are created, that these are controllable. (E.g. that they respond to docker compose down -v, which removes all managed volumes.)

Changes to the Wiki

n/a

Proposed Release Note Entry

Pre-defined volume for the caching redis, to prevent the container runtime from creating an temporary unmanaged volume.

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@Delta1977 Delta1977 changed the title Mitoigate: Docker creating temporary random volume for Redis Cache on every Restart Mitigate: Docker creating temporary random volume for Redis Cache on every Restart Sep 23, 2022
@cimnine cimnine added maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. enhancement The issue describes an enhancement that we would like to implement in the future. and removed maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. labels Oct 6, 2022
@cimnine cimnine self-assigned this Oct 6, 2022
@cimnine
Copy link
Collaborator

cimnine commented Oct 6, 2022

I've updated the PR description. Please follow the template next time.

@cimnine cimnine changed the title Mitigate: Docker creating temporary random volume for Redis Cache on every Restart Define a volume for the caching Redis Oct 6, 2022
@cimnine cimnine enabled auto-merge October 6, 2022 19:37
@cimnine cimnine merged commit c21a29b into netbox-community:develop Oct 6, 2022
@cimnine cimnine mentioned this pull request Oct 25, 2022
3 tasks
@tobiasge tobiasge mentioned this pull request Dec 15, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue describes an enhancement that we would like to implement in the future.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants