Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed bzip2 #836

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Installed bzip2 #836

merged 1 commit into from
Aug 31, 2022

Conversation

tobiasge
Copy link
Member

Related Issue: #811

New Behavior

  • Backup command examples from wiki ware working

Contrast to Current Behavior

  • Our own examples don't work

Discussion: Benefits and Drawbacks

  • None

Changes to the Wiki

  • None

Proposed Release Note Entry

  • None

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

In the Wiki backup section we use bzip2 in some of the examples. So it should be installed in the image.
@tobiasge tobiasge requested a review from cimnine August 31, 2022 12:14
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say 'adjust the wiki' , but then old backups would probably not work anymore.

@tobiasge
Copy link
Member Author

I think it's ok to add it. Bzip2 doesn't pull in any extra dependencies and in itself is very small.

@tobiasge tobiasge enabled auto-merge August 31, 2022 12:28
@tobiasge tobiasge merged commit e48ab08 into netbox-community:develop Aug 31, 2022
@tobiasge tobiasge deleted the fix-for-811 branch August 31, 2022 14:00
@tobiasge tobiasge mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants