Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements for OIDC SSO #786

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Add requirements for OIDC SSO #786

merged 1 commit into from
Jul 19, 2022

Conversation

rjmidau
Copy link

@rjmidau rjmidau commented Jul 4, 2022

Resolves #769

New Behavior

Extends requirements to enable the use of OpenID Connect SSO Providers from Python Social Auth.

Contrast to Current Behavior

Currently these dependencies aren't included, meaning users can't take advantage of OIDC SSO unless they create their own image.

Discussion: Benefits and Drawbacks

  • Benefit: Enabling users to use functionality included in Netbox without needing to create bespoke images.
  • Drawback: Additional dependencies increase the image size, and the version pinning will need to be periodically reviewed
  • Backwards-compatible: Yes

Changes to the Wiki

None

Proposed Release Note Entry

Requirements needed to use OpenID Connect SSO Providers have been added

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge merged commit e62fedb into netbox-community:develop Jul 19, 2022
@rjmidau rjmidau deleted the oidc branch July 19, 2022 12:11
@tobiasge tobiasge mentioned this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants