Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH_LDAP_BIND_AS_AUTHENTICATING_USER is now loaded from environment #779

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

BegBlev
Copy link
Contributor

@BegBlev BegBlev commented Jun 20, 2022

Related Issue: #690

New Behavior

Providing AUTH_LDAP_BIND_AS_AUTHENTICATING_USER environment variable, Netbox container binds to LDAP server using username and password provided by the user being authenticated.

Contrast to Current Behavior

Currently, as described in issue #690 this parameter is not taken into account.

Discussion: Benefits and Drawbacks

No service user/password are needed.

Changes to the Wiki

N/A

Proposed Release Note Entry

Fix: It is now possible to bind Netbox container to LDAP server using user login/password.

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@BegBlev
Copy link
Contributor Author

BegBlev commented Sep 2, 2022

Hi,
This is a very simple and short merge request.
Is there something I can do to help progress on this topic?
Best regards.
Vincent

@tobiasge
Copy link
Member

tobiasge commented Sep 5, 2022

The default value for this parameter in django-auth-ldap is False. I don't think we should override it with our own.

@BegBlev
Copy link
Contributor Author

BegBlev commented Sep 9, 2022

@tobiasge I agree :)
I just commited a the change.
Thank you

@BegBlev
Copy link
Contributor Author

BegBlev commented Sep 21, 2022

@tobiasge do you approve the modification?

@tobiasge tobiasge merged commit d385cd2 into netbox-community:develop Sep 21, 2022
@cimnine cimnine mentioned this pull request Oct 25, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants