-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact startups #728
Contact startups #728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added line at end
Hi @Lon1, recently there has been a merge to the develop branch and now all startup_scripts are made idempotent. |
@kr3ator - I've made the requested changes, hopefully all the checks pass this time! |
@kr3ator - hold off! - I didn't see the use for match_params further above in your script. Please standby. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done adding match_params assignments @kr3ator
@kr3ator - I fixed the linting issues, but I still don't have the split_params function. Will you just merge anyway? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed linting issues
You should rebase your branch onto the current develop branch. Then you will have the function. |
@kr3ator - should be rebased, please try again. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I should have viewed all these and submitted previously.
eb8d4f1
to
047f2ab
Compare
Related Issue:
New Behavior
Adding Contact, Contact Group, Contact Role startup scripts along with corresponding initialization yaml file examples.
Contrast to Current Behavior
Created new contact startup scripts feature that will execute at startup of NetBox.
Discussion: Benefits and Drawbacks
Contact objects were recently added to NetBox and did not have any corresponding startup scripts. There are no drawbacks, should be backwards compatible as far as when Contacts were added. I did not include Tags as an option in the yaml files, but did include custom fields.
Changes to the Wiki
The Wiki doesn't need updated.
Proposed Release Note Entry
Contact, Contact Group, Contact Role startup scripts added.
Double Check
develop
branch.