update account properties,fix issue #676 #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanmerolle can you review this for starting workflow? |
changed default values to First and Last name and is_active field
|
looks like failed test is broken |
|
Fixed by PR #729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #676
New Behavior
Set First_name, Last_name, email, and permissions properties as we set in yml
Contrast to Current Behavior
First_name, Last_name, email, and permissions properties was not used for account creation
Discussion: Benefits and Drawbacks
Work as it designed and fixed issue request
Changes to the Wiki
No
Proposed Release Note Entry
Fix wrong behaviour while creating users with init startup scripts
Double Check
developbranch.