Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
New Behavior
In the past, it was difficult to align the version of NetBox (e.g. currently
v3.0.2
) and the version of NetBox Docker (e.g. currentlyv1.4.0
).Contrast to Current Behavior
This PR changes the build script and introduces an additional Docker tag for all the built tags. The additional tag contains
-${PROJECT_VERSION}
. Some examples:latest-ldap
will also be taggedlatest-ldap-1.4.0
v3.0-ldap
will also be taggedv3.0-ldap-1.4.0
v3.0.2-ldap
will also be taggedv3.0.2-ldap-1.4.0
snapshot-ldap
will also be taggedsnapshot-ldap-1.4.0
latest
will also be taggedlatest-1.4.0
v3.0
will also be taggedv3.0-1.4.0
v3.0.2
will also be taggedv3.0.2-1.4.0
snapshot
will also be taggedsnapshot-1.4.0
Discussion: Benefits and Drawbacks
Once a new version of NetBox Docker is released, only Docker images for the at-that-time current NetBox version (and all later versions) will be produced. For example, if we release this PR as
v1.4.1
, thenv3.0.2-1.4.1
would be tagged, but for example notv3.0.1-1.4.1
.Also, older versions of NetBox Docker will not get new NetBox releases. So, if we release this PR as
v1.4.1
, and we would have already an image tagged asv3.0.2-1.4.0
, then – when NetBox releasesv3.0.3
, a tag such asv3.0.3-1.4.0
would not be produced. Onlyv3.0.3-1.4.1
would be built.That is a good-enough tradeoff for now IMO.
Changes to the Wiki
n/a
Proposed Release Note Entry
Tags containing the corresponding NetBox Docker project version will be available from now on for our Docker images. For example,
v3.0.2-ldap-1.4.1
would be such a tag. Thev3.0.2
corresponds to the version of the NetBox project, while1.4.1
corresponds to the version of the NetBox Docker project.Double Check
develop
branch.