Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if remote branch exists before checkout #579

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Check if remote branch exists before checkout #579

merged 2 commits into from
Sep 13, 2021

Conversation

tobiasge
Copy link
Member

Related Issue: -

New Behavior

  • Check if the remote branch exists before checkout

Contrast to Current Behavior

  • Checkout error when remote Netbox remote branch doesn't exist

Discussion: Benefits and Drawbacks

  • Better feedback message than a git error

Changes to the Wiki

  • None

Proposed Release Note Entry

  • None

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine September 13, 2021 07:54
cimnine
cimnine approved these changes Sep 13, 2021
View reviewed changes
@tobiasge @cimnine
Improved check
c4d545a 
Co-authored-by: Christian Mäder <[email protected]>
@tobiasge tobiasge merged commit c00492c into netbox-community:develop Sep 13, 2021
@tobiasge tobiasge deleted the check-remote branch September 13, 2021 21:42
@tobiasge tobiasge mentioned this pull request Sep 17, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine