Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added container for Netbox housekeeping command #571

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Sep 3, 2021

Related Issue: #558

New Behavior

  • Run Netbox housekeeping command periodically

Contrast to Current Behavior

  • Changelogs will be kept indefinitely even when CHANGELOG_RETENTION is set

Discussion: Benefits and Drawbacks

  • I tried to use a real cron to run the command on a schedule, but this will not work properly with the random user IDs used in K8s or Openshift

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Added container for Netbox housekeeping command

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

Adds an additional container in which the new "housekeeping" command from
Netbox v3.0.0 is run.
@tobiasge
Copy link
Member Author

tobiasge commented Sep 3, 2021

As replacement for #559 with fewer changes.

@tobiasge tobiasge requested a review from cimnine September 3, 2021 10:53
@tobiasge tobiasge added this to the Version 1.4.0 milestone Sep 3, 2021
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker/housekeeping.sh Outdated Show resolved Hide resolved
Co-authored-by: Christian Mäder <[email protected]>
@cimnine cimnine added the enhancement The issue describes an enhancement that we would like to implement in the future. label Sep 10, 2021
@tobiasge tobiasge merged commit 8703749 into netbox-community:develop Sep 17, 2021
@tobiasge tobiasge deleted the house branch September 17, 2021 08:53
@tobiasge tobiasge mentioned this pull request Sep 17, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue describes an enhancement that we would like to implement in the future.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants