Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops privileges to user 101 and group 0 #546

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Jul 30, 2021

Related Issue: #506, #509

New Behavior

  • Explicit drop of privileges to the user and group we need

Contrast to Current Behavior

  • Unit is defaulting to "unit:unit" user

Discussion: Benefits and Drawbacks

  • Should fixes the problems with temporary files that can't be created

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Fix permissions errors with temporary files

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

When the container is started as root the default was to drop privileges to "unit:unit". This caused some problems with temporary files. Now the privileges are drop to "101:0".
When the container is started as a normal user unit prints a warning that changing the user and group is not possible. This warning is safe to ignore.
@tobiasge tobiasge requested a review from cimnine July 30, 2021 19:49
@tobiasge
Copy link
Member Author

Tested with: Normal user, root on Debian 10 and on Openshift 4.6.

@cimnine cimnine added the bug This issue describes a confirmed bug. label Aug 2, 2021
@cimnine cimnine added this to the next milestone Aug 2, 2021
@tobiasge tobiasge modified the milestones: next, Version 1.4.0 Sep 3, 2021
@tobiasge tobiasge merged commit 1d040ad into netbox-community:develop Sep 17, 2021
@tobiasge tobiasge deleted the drop-privileges branch September 17, 2021 08:53
@tobiasge tobiasge mentioned this pull request Sep 17, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants