Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for Netbox v3.0.0 #543

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Prepare for Netbox v3.0.0 #543

merged 3 commits into from
Aug 30, 2021

Conversation

tobiasge
Copy link
Member

Related Issue: -

New Behavior

  • Changes to build Netbox v3.0.0 images correctly

Contrast to Current Behavior

  • Not compatible with new Netbox version

Discussion: Benefits and Drawbacks

  • None

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Changed build to work with Netbox v3.0.0 (and hopefully above)

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge force-pushed the prepare-3.0.0 branch 3 times, most recently from ae6e479 to 9b2c7aa Compare July 30, 2021 19:51
@cimnine
Copy link
Collaborator

cimnine commented Aug 2, 2021

What do you see as the benefit of creating the documentation during the build?

@tobiasge
Copy link
Member Author

tobiasge commented Aug 2, 2021

For version 3.0 the documentation link in the UI points to the local documentation and not to netbox.readthedocs.io
This link would produce a 404 if we don't build the documentation. See this issue.

@tobiasge tobiasge marked this pull request as ready for review August 30, 2021 15:07
@tobiasge tobiasge requested a review from cimnine August 30, 2021 15:07
cimnine
cimnine approved these changes Aug 30, 2021
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@tobiasge tobiasge merged commit 1fd8d10 into netbox-community:develop Aug 30, 2021
@tobiasge tobiasge deleted the prepare-3.0.0 branch August 30, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine