Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish Netbox on random port #495

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

tobiasge
Copy link
Member

Related Issue:

New Behavior

  • Netbox UI is not accessible on a random port.

This improves on PR #407 with an added example file for the docker-compose.override.yml to make it as easy as possible for new users to get an instance of Netbox running. Thanks to @centum for the initial PR.

Contrast to Current Behavior

  • Netbox can be accessed on a random port from outside of the server it is running on.

Discussion: Benefits and Drawbacks

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Netbox is not published on a random port anymore. The port configuration must be set in the docker-compose.override.yml file.

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine April 17, 2021 08:24
@tobiasge tobiasge merged commit 6879412 into netbox-community:develop Apr 19, 2021
@tobiasge tobiasge deleted the no-random-port branch April 19, 2021 09:33
@cimnine cimnine added this to the 1.2.0 milestone Apr 19, 2021
@cimnine cimnine added the maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. label Apr 19, 2021
@cimnine cimnine mentioned this pull request Apr 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants