Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializer updates for Netbox 2.11 #485

Merged
merged 8 commits into from
Apr 16, 2021
Merged

Initializer updates for Netbox 2.11 #485

merged 8 commits into from
Apr 16, 2021

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Apr 7, 2021 •
edited
Loading

New Behavior

  • Startup scripts run with Netbox 2.11

Contrast to Current Behavior

  • Initializers won't work with new Netbox version

Discussion: Benefits and Drawbacks

  • Updates are necessary for Netbox 2.11

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Compatibility with Netbox 2.11

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge changed the title Rack groups have been renamed to locations Initializer updates for Netbox 2.11 Apr 7, 2021
cimnine
cimnine reviewed Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read the release notes right, then — with NB 2.11 — devices can also be assigned to a location. Maybe you could add that?

@tobiasge
Copy link
Member Author

tobiasge commented Apr 7, 2021

Changes for the change netbox-community/netbox#5284 will follow.

@tobiasge
Copy link
Member Author

tobiasge commented Apr 7, 2021

Prerelease Checks are green now. Should be OK to review.

@tobiasge tobiasge requested a review from cimnine April 7, 2021 13:43
cimnine
cimnine approved these changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's great to be ready when the next NetBox minor drops 🎉 I have left some remarks which you may want to consider, or maybe not.

cimnine
cimnine requested changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small oversight here, no biggie :)

@tobiasge @cimnine
Fixed Python f-string
752f592 
Co-authored-by: Christian Mäder <[email protected]>
@tomasaberg
Copy link

Sweet with updates, thank you for your work!
do you intend to update the groups and permissions as well, as discussed on this issue #449?

@cimnine cimnine added the maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. label Apr 16, 2021
@tobiasge tobiasge marked this pull request as ready for review April 16, 2021 17:58
@tobiasge
Copy link
Member Author

Netbox 2.11 is released.

@tobiasge tobiasge merged commit c7df608 into netbox-community:develop Apr 16, 2021
@tobiasge tobiasge deleted the prepare-2.11 branch April 16, 2021 18:00
@cimnine cimnine added this to the 1.2.0 milestone Apr 19, 2021
@cimnine cimnine mentioned this pull request Apr 23, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasge @tomasaberg @cimnine