-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildx: Build Cache and Platforms #474
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e504b75
to
9410c87
Compare
I will re-open this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: #468, #306
TODO
error: failed to solve: rpc error: code = Unknown desc = docker exporter does not currently support exporting manifest lists
docker-compose up
on a Raspberry PI (or other ARM computer)New Behavior
We were using Docker Buildx in our scripts since a while.
We used it via
docker build
by exporting the respective ENV var,DOCKER_BUILDKIT=1
.This change switches to using
docker buildx
commands explicitly.This allows us to use more advanced features:
linux/arm64
Contrast to Current Behavior
Currently only the most basic features of Buildx can be used, because Docker does not expose the advanced features through the
docker build
command.Discussion: Benefits and Drawbacks
My main hope is that this change speeds up builds. Because the build-cache can be exported, GH Action should be able to restore the build-cache the next time it attempts a build. This should even be true for branch builds, i.e. builds for PRs.
Changes to the Wiki
I don't think that changes are required.
Proposed Release Note Entry
## ARM64 Builds #474 We now build and ship an ARM64 build of the image. This was made possible by switching to the Buildx build system.
Double Check
develop
branch.