Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH_LDAP_MIRROR_GROUPS ldap_config tweak #448

Merged
merged 7 commits into from
Apr 20, 2021
Merged

AUTH_LDAP_MIRROR_GROUPS ldap_config tweak #448

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
020e0ad
update .gitignore to keep extra.py in ldap config
ryanmerolle Feb 22, 2021
22186b2
do not set AUTH_LDAP_MIRROR_GROUPS if not defined
ryanmerolle Feb 22, 2021
0dec4d8
Add extra.py example for ldap config
ryanmerolle Feb 22, 2021
f19d650
Merge pull request #1 from netbox-community/develop
ryanmerolle Feb 25, 2021
28a2628
Merge pull request #3 from netbox-community/develop
ryanmerolle Apr 20, 2021
222ede2
enahance ldap extra.py with more examples
ryanmerolle Apr 20, 2021
6f4d025
backed out ldap_config changes
ryanmerolle Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ configuration/*
!configuration/extra.py
configuration/ldap/*
!configuration/ldap/ldap_config.py
!configuration/ldap/extra.py
prometheus.yml
super-linter.log
8 changes: 8 additions & 0 deletions configuration/ldap/extra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
####
## This file contains extra configuration options that can't be configured
## directly through environment variables.
####

# import ldap
ryanmerolle marked this conversation as resolved.
Show resolved Hide resolved

# AUTH_LDAP_MIRROR_GROUPS = ["netbox-group-1", "netbox-group-2"]
3 changes: 2 additions & 1 deletion configuration/ldap/ldap_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ def _import_group_type(group_type_name):

# For more granular permissions, we can map LDAP groups to Django groups.
AUTH_LDAP_FIND_GROUP_PERMS = environ.get('AUTH_LDAP_FIND_GROUP_PERMS', 'True').lower() == 'true'
AUTH_LDAP_MIRROR_GROUPS = environ.get('AUTH_LDAP_MIRROR_GROUPS', '').lower() == 'true'
if environ.get('AUTH_LDAP_MIRROR_GROUPS') is not None:
ryanmerolle marked this conversation as resolved.
Show resolved Hide resolved
AUTH_LDAP_MIRROR_GROUPS = environ.get('AUTH_LDAP_MIRROR_GROUPS', '').lower() == 'true'

# Cache groups for one hour to reduce LDAP traffic
AUTH_LDAP_CACHE_TIMEOUT = int(environ.get('AUTH_LDAP_CACHE_TIMEOUT', 3600))
Expand Down