Variables to control plugins #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugins: - PLUGINS: list of plugins in this form -> PLUGINS="plug1,plug2" - PLUGINS_CONFIG: json string -> dict()
cimnine
added
the
enhancement
cimnine
changed the title
Closed
|
Thanks for your PR. I don't like the JSON parsing, but such dynamic configuration is an issue in other PRs as well. That's why I've started a discussion issue here: #318 |
cimnine
added
the
discussion
|
Please let me know if #343 would be a good enough solution for your use-case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
New Behavior
Use the environment variable PLUGINS and PLUGINS_CONFIG so you can use the image (+ plugins you installed there) "as-is" without editing its configuration files.
...
Contrast to Current Behavior
You need to play with custom dockerfile and init scripts in order to get plugins to work, now you only need to
pip installfrom custom dockerfile....
Discussion: Benefits and Drawbacks
proposed change?
Adding line in order to INSTALL a plugin is ok, but getting the relevant variables in netbox environment, within docker is super-sketchy : much easier with just env vars.
I don't see any.
Yes.
No!
...
Changes to the Wiki
...
Proposed Release Note Entry
...
Double Check
developbranch.