Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PostgreSQL to 11 #195

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Update PostgreSQL to 11 #195

merged 2 commits into from
Dec 20, 2019

Conversation

cimnine
Copy link
Collaborator

@cimnine cimnine commented Nov 26, 2019

No description provided.

@cimnine cimnine added the maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. label Nov 26, 2019
@cimnine cimnine added this to the 0.16.0 milestone Nov 26, 2019
@cimnine cimnine requested a review from tobiasge November 26, 2019 11:25
Copy link
Member

@tobiasge tobiasge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I run the tests from netbox with Postgres 12 I had some failures, that weren't there with 10 or 11. If they are gone now, I think the upgrade is OK. If not we should only go to version 11.

@cimnine cimnine changed the base branch from master to develop December 10, 2019 20:48
@cimnine
Copy link
Collaborator Author

cimnine commented Dec 10, 2019

If they are gone now, I think the upgrade is OK. If not we should only go to version 11.

I did not do extended testing, so I trust in your judgment. 11 it is for now.

@cimnine cimnine changed the title Update PostgreSQL to 12 Update PostgreSQL to 11 Dec 14, 2019
@cimnine cimnine requested a review from tobiasge December 16, 2019 12:05
Copy link
Member

@tobiasge tobiasge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to go to 11.x so we always have the current minor version 👍

@cimnine cimnine merged commit 28c786c into develop Dec 20, 2019
@cimnine cimnine deleted the update-postgres branch December 20, 2019 10:43
@cimnine cimnine mentioned this pull request Dec 21, 2019
@steinbachio
Copy link

Hi!
we tried to upgrade from Netbox v2.6.7 to v2.6.11 (ldap) and also updated docker-compose to the latest version and the postgres 11 container exited with the following message:

docker logs -f 1a

PostgreSQL Database directory appears to contain a database; Skipping initialization

2020-01-13 13:56:03.279 UTC [1] FATAL: database files are incompatible with server
2020-01-13 13:56:03.279 UTC [1] DETAIL: The data directory was initialized by PostgreSQL version 10, which is not compatible with this version 11.6.

PostgreSQL Database directory appears to contain a database; Skipping initialization

2020-01-13 13:56:37.431 UTC [1] FATAL: database files are incompatible with server
2020-01-13 13:56:37.431 UTC [1] DETAIL: The data directory was initialized by PostgreSQL version 10, which is not compatible with this version 11.6.

PostgreSQL Database directory appears to contain a database; Skipping initialization

2020-01-13 14:11:43.880 UTC [1] FATAL: database files are incompatible with server
2020-01-13 14:11:43.880 UTC [1] DETAIL: The data directory was initialized by PostgreSQL version 10, which is not compatible with this version 11.6.

is there a prefered way to upgrade the database?

Thank you!

@cimnine
Copy link
Collaborator Author

cimnine commented Jan 13, 2020

Thank you for making me aware of this. Since I only use the Docker image for development, I can not provide a tried-and-tested answer to that question of yours.

There seem to be several proposals flowing around:

Note that there is no requirement to update to PostgreSQL 11, you can stick to version 10 just fine.
You could do this with a docker-compose.override.yml like so:

version: '3.4'
services:
  postgres:
    image: postgres:10-alpine

I have added a note to the preliminary changelog of the 0.20.0 release about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants