Added more startup_scripts and initializers examples. #143
Conversation
There was a problem hiding this comment.
Thank you a lot for this PR. It must have been hard work figuring all this out. I feel a little bit bad for adding so many remarks. Could you please see through them and either fix them or otherwise add a short note if you don't agree or if what I ask for is too much work.
Again, thank you very much for sharing your work with the community.
cimnine
added
the
enhancement
|
@axarriola Are you still interested in getting this PR merged? Have you had the chance to look at my comments? |
|
Hi @cimnine , of course, I've already fixed over half of the comments. I've just been swamped with work in the last weeks. Hopefully I will get some time this week to finish everything. Is that ok? |
|
Cool! Don't worry and take your time. |
|
@cimnine Just wanted to let you know that this is still on my to-do list, just haven't found the time, but I'll get to it. |
|
FYI: Don't worry about the failing build. That's something I'm working on in parallel. |
|
I'm still missing a few comments, working on those at the moment. |
|
@cimnine Now all the remarks have been taken care of! Due to some events today I had some free time. Kindly let me know if there is anything else |
There was a problem hiding this comment.
I'm very excited about these initializers! But I have some more comments before I'm confident to merge those.
Please have a look on the remarks – and feel free to disagree where you believe this is due. For all that matters, we can turn a blind eye to all the comments on the yaml files. (But please don't resolve them when they're not actually resolved.)
|
I submitted another commit. To my knowledge I changed all the remarks to the .yaml files, I went one by one, let me know which ones weren't updated. |
There was a problem hiding this comment.
I was a little bit disappointed when I commented in all the yamls and Netbox was not able to start. Nevertheless, here are some more suggestions and fixes.
Please make sure, that – when enabling all the code in the yaml files, and with a clean database – a docker-compose up succeeds. (You can clean the database with docker-compose down -v.)
I've also made some changes to the master branch regarding the initializers, which you might want to merge into your branch. (Or a rebase + force-push is fine with me as well.)
initializers/prefixes.yml
Outdated
| # vlan: vlan2 | ||
| # is_pool: true | ||
| # vrf: vrf2 | ||
| # tenant: tenant2 |
There was a problem hiding this comment.
The tenant key is defined twice. Duplicate keys are not allowed by the Netbox code.
| # tenant: tenant2 |
|
I submitted all the changes and tested them before in a new netbox-docker on a fresh VM. |
Summary
Added more startup_scripts and initializers examples for further Netbox objects.
Files
initializers/aggregates.yml
initializers/cluster_types.yml
initializers/clusters.yml
initializers/dcim_interfaces.yml
initializers/ip_addresses.yml
initializers/prefixes.yml
initializers/rirs.yml
initializers/tenants.yml
initializers/virtual_machines.yml
initializers/virtualization_interfaces.yml
initializers/vlan_groups.yml
initializers/vlans.yml
initializers/vrfs.yml
startup_scripts/104_tenant_groups.py
startup_scripts/105_tenants.py
startup_scripts/120_cluster_types.py
startup_scripts/125_rirs.py
startup_scripts/130_aggregates.py
startup_scripts/150_clusters.py
startup_scripts/155_vrfs.py
startup_scripts/160_prefix_vlan_roles.py
startup_scripts/170_vlan_groups.py
startup_scripts/180_vlans.py
startup_scripts/190_prefixes.py
startup_scripts/200_virtual_machines.py
startup_scripts/210_virtualization_interfaces.py
startup_scripts/215_dcim_interfaces.py
startup_scripts/220_ip_addresses.py