Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP_PROXIES related parameters #1255

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

threes33
Copy link
Contributor

@threes33 threes33 commented Jun 4, 2024

Related Issue: N/A

New Behavior

Configure HTTP_PROXIES settings for http/https scheme through environment variable using HTTP_PROXY and HTTPS_PROXY

Contrast to Current Behavior

There is currently no support to configure this through an environment variable so a custom configuration must be created

Discussion: Benefits and Drawbacks

Makes it easier to set http proxies

Changes to the Wiki

N/A

Proposed Release Note Entry

Support the following environment variables for HTTPS_PROXIES:

  • HTTP_PROXY
  • HTTPS_PROXY

Also see: https://netboxlabs.com/docs/netbox/en/stable/configuration/system/#http_proxies

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

tobiasge and others added 3 commits May 6, 2024 21:26
Version 2.9.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Version 2.9.1

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please see my question below.

configuration/configuration.py Show resolved Hide resolved
@cimnine cimnine requested a review from tobiasge June 4, 2024 20:37
@cimnine cimnine merged commit 8017bb7 into netbox-community:develop Jun 6, 2024
9 checks passed
@tobiasge tobiasge mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants