Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xmlsec with no-binary option #1230

Merged
merged 2 commits into from
May 25, 2024
Merged

Conversation

lchastel
Copy link
Contributor

@lchastel lchastel commented May 9, 2024

SAML backend is still not working.
I have the issue "lxml & xmlsec libxml2 library version mismatch".

Related Issue:

New Behavior

Adding xmlsec to requirements-container.txt for python3-saml like it's done for lxml solve the issue.

Contrast to Current Behavior

When enabling SAML backend, I receives the error message
lxml & xmlsec libxml2 library version mismatch

How to reproduce ?

  • Follow Quickstart of netbox-docker

  • Add next lines to env/netbox.env
    REMOTE_AUTH_BACKEND='social_core.backends.saml.SAMLAuth'
    DEBUG=true

  • Start or restart netbox
    docker compose up -d

  • Connect to the netbox instance (you may have to click on login)
    Here is the result ...
    saml_netbox

Discussion: Benefits and Drawbacks

...

Changes to the Wiki

...

Proposed Release Note Entry

...

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

SAML backend is still not working.
I have the issue  "lxml & xmlsec libxml2 library version mismatch".
@cimnine cimnine changed the base branch from release to develop May 25, 2024 13:14
@cimnine
Copy link
Collaborator

cimnine commented May 25, 2024

Thanks for the PR. This looks fine to me, what do you think @tobiasge ? @lchastel could you update your PR with the latest changes from the develop branch?

@cimnine cimnine requested a review from tobiasge May 25, 2024 13:16
@tobiasge tobiasge enabled auto-merge May 25, 2024 13:22
@tobiasge tobiasge merged commit d4e9401 into netbox-community:develop May 25, 2024
9 checks passed
@lchastel lchastel deleted the saml branch June 4, 2024 07:46
@jonlarsdizparc
Copy link

@cimnine Should this fix be automatically updated into new docker hub builds? I'm still experiencing these issues on version v4.0.5-2.9.1 (updated 2 days ago).

@cimnine
Copy link
Collaborator

cimnine commented Jun 10, 2024

It will be when we release a new version of the NB Docker project. (That's the 2.9.1 part of the tag)

@lchastel
Copy link
Contributor Author

lchastel commented Jun 10, 2024

If you need the correction, you could temporary use my image, docker pull ghcr.io/lchastel/netbox-docker:snapshot-2.9.1
I made it 4 days ago, from develop branch.

@cimnine : Could you please check the Github Actions workflow ? (cf #1258)
Except if I made a mistake, the job "Builds new NetBox Docker Images (./build.sh develop, ubuntu-latest)" should create a new image from develop branch and push it as snapshot (or snapshot-2.9.1) ... but the file /opt/netbox/requirements-container.txt is the one from release branche.
I checked on latest workflow "Merge pull request #1260 from netbox-community/renovate/sentry-sdk-2.x #1440"
I also pull the latest image with snapshot from dockerhub (docker pull netboxcommunity/netbox:snapshot)
sha256:59f03c3086462aea7c435ffb057575ace74098a960cd9567bfd27418bf563102
The image does not contains the file /opt/netbox/requirements-container.txt in version of develop branch.

@jonlarsdizparc
Copy link

If you need the correction, you could temporary use my image, docker pull ghcr.io/lchastel/netbox-docker:snapshot-2.9.1 I made it 4 days ago, from develop branch.

Thank you! I'll use it until the next version has been published.

@tobiasge tobiasge mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants