-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOCIAL_AUTH settings in custom configuration files, are not picked up in 3.1 beta1 #653
Comments
The only "working" solution I have found so far, is exec'ing into the container, adding: killing the PID's of the unit processes for the netbox app, so not a super viable solution, but that way they work as expected. |
I think the problem is the missing |
Thanks, sure I'll give it a spin tomorrow morning and post the results. |
Tested it now, and it seems to work fine with the image you posted, so that seems to fix it :) |
Thank you for opening a bug report. This bug appears to not be related to NetBox. |
Hi Dan. This is the NetBox Docker repository and it was definitely related to our code for loading the configuration from multiple files. Tobias fixed it in #656. That's the only reason to close the issue. Cheers |
Whoops, lol, sorry about that, I wasn't paying attention. My bad |
Now netbox v3.1 has been released, not just in beta, using the official 3.1 docker image, this fix in the develop branch doesn't seem to be included, do any of you have an idea, when those will be merged into master? (which is guess is what the images/tags on dockerhub is created from daily?). |
Current Behavior
Tried just adding them as:
SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_RESOURCE = 'xxx'
SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_KEY = 'xxx'
SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_SECRET = 'xxx'
SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_TENANT_ID = 'xxx'
to extra.py in /etc/netbox/config/
Changing other variables like ADMIN_USERS in extra.py works fine, so the file itself is getting read, just not these specific variables.
They didn't show up in the django debug toolbar.
I'm guessing it's related to how the latest netbox reads the specific variables:
netbox-community/netbox@200aca4#diff-310332579486e53e626dd095399f64c29fc215b386672af995b764f78328d27e
Expected Behavior
Expected the settings to be picked up, and listed in the django debug toolbar (settings).
Docker Compose Version
N/A (used the netboxcommunity/netbox:v3.1-beta1 image on docker hub)
Docker Version
The git Revision
netboxcommunity/netbox:v3.1-beta1
The git Status
Startup Command
N/A
NetBox Logs
Content of docker-compose.override.yml
N/A
The text was updated successfully, but these errors were encountered: