-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to release/development branching model #184
Comments
I'm thinking about ditching the name |
I would use |
What's left to do:
|
Prepares scripts and documentation for #184
Please point the default branch to 'release' instead of 'develop'. It's a bit confusing the follow the guide and not get working environment, for example due to non-working develop branch. |
First, there's good new for you: In the meantime, existing users should not be affected, since there is still a master branch. Once 0.20.0 is merged, people should update to the release branch. Any further The only concern is new users. For them, we have updated the instructions to clone the project to the following command. It causes the release branch to be automatically checked out. So if people follow the guide, they will get it right. git clone -b release https://github.com/netbox-community/netbox-docker.git Edit: The wiki page Getting Started pointed to |
Current Behavior
Currently, the
master
branch is where development happens, and which PRs usually target.But it's also the branch where all the Docker images are built from.
This leads to situations, where we merge PRs to the master branch, and - when not immediately releasing the branch - the Docker images are getting tagged with a wrong version.
Expected Behavior
The version, which the label on the Docker image portraits, must always be accurate. This helps debugging any issues.
Therefore I suggest the following change of the development workflow:
main
branch continues to be themaster
branch. It must be stable. People clone this branch to get started with the Netbox Docker project. The Docker images continue to be built from this branch.develop
branch (like the Netbox project already has) to which we continually merge PRs and on which new features are developed and tested. Whenever we decide it's time for a release, we adjust the VERSION file tox.y.z
, mergedevelop
tomaster
, tag that merge-commit with the VERSION number, and finally adjust the VERSION file on thedevelop
branch tox.y.z+1-develop
.The text was updated successfully, but these errors were encountered: