Merge pull request #1240 from tobiasge/login-required-default

Change LOGIN_REQUIRED default to 'True'
netbox-community · May 21, 2024 · 94e2421 · 94e2421
2 parents b746883 + 8c691f1
commit 94e2421
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/configuration/configuration.py b/configuration/configuration.py
@@ -221,9 +221,9 @@ def _environ_get_and_map(variable_name: str, default: str | None = None, map_fn:
 # authenticated to NetBox indefinitely.
 LOGIN_PERSISTENCE = _environ_get_and_map('LOGIN_PERSISTENCE', 'False', _AS_BOOL)
 
-# Setting this to True will permit only authenticated users to access any part of NetBox. By default, anonymous users
-# are permitted to access most data in NetBox (excluding secrets) but not make any changes.
-LOGIN_REQUIRED = _environ_get_and_map('LOGIN_REQUIRED', 'False', _AS_BOOL)
+# When enabled, only authenticated users are permitted to access any part of NetBox.
+# Disabling this will allow unauthenticated users to access most areas of NetBox (but not make any changes).
+LOGIN_REQUIRED = _environ_get_and_map('LOGIN_REQUIRED', 'True', _AS_BOOL)
 
 # The length of time (in seconds) for which a user will remain logged into the web UI before being prompted to
 # re-authenticate. (Default: 1209600 [14 days])

diff --git a/test-configuration/test_config.py b/test-configuration/test_config.py
@@ -4,3 +4,4 @@
 }
 
 DEFAULT_PERMISSIONS = {}
+LOGIN_REQUIRED = False
diff --git a/test.sh b/test.sh
@@ -84,7 +84,7 @@ test_netbox_web() {
       --retry 5 \
       --retry-delay 0 \
       --retry-max-time 40 \
-      http://127.0.0.1:8000/
+      http://127.0.0.1:8000/login/
   )
   if [ "$RESP_CODE" == "200" ]; then
     echo "Webservice running"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,3 +4,4 @@
		}

		DEFAULT_PERMISSIONS = {}
		LOGIN_REQUIRED = False