Netbox 3.6 #175
Closed
Netbox 3.6 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…box_3.6 netbox 3.6 support (Sourcery refactored)
…dability - Remove unnecessary variable assignments and use self.cleaned_data directly - Replace forms.ValidationError with ValidationError for consistency - Simplify error message assignment by raising ValidationError directly - Remove redundant comments and add more meaningful ones - Simplify object filtering by removing unnecessary get calls - Use dictionary for ValidationError messages to specify field errors - Simplify assignment of assigned_object_id and assigned_object_type_id - Simplify error message assignment in ACLExtendedRuleForm clean method
…r with forms.ChoiceField
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
Installing this PR into Netbox 3.7.4 running under LXC container (Debian 12, Python 3.11) seems to work without obvious issues. (Not using docker!) Install the plugin Modify the maximum allowed version to < 3.8 Run the migration script Enable the Restart netbox |
|
I merged the changes for 3.6 into the repo. I had issues with cherrypicking and such, but I named @kbelokon in the release notes given the support provided. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
This PR completes the work started in #167 for transitioning to NetBox version 3.6.
New Behavior
I have finished the implementation for transitioning to NetBox version 3.6, as initiated in PR #167. My changes ensure full compatibility and functionality with this version of NetBox.
Contrast to Current Behavior
Unlike the current state in the branch of PR #167, where the transition to NetBox 3.6 was incomplete, my changes fully support this version, resolving all known issues and incompatibilities.
Changes to the Documentation
No updates to the documentation are required as the changes pertain only to internal compatibility with the new version of NetBox.
Proposed Release Note Entry
"Added support for NetBox version 3.6, completing the work started in PR #167. Ensures full compatibility and functionality with the new version."
Double Check
devbranch.