Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate client from swagger json #52

Closed
wants to merge 8 commits into from

Conversation

mraerino
Copy link
Collaborator

@mraerino mraerino commented Jan 5, 2020

Focussed on these goals:

  • Generate client from swagger.json
  • Simplify structure of package (breaking change)
    • models and client directories

Todos:

  • Have up-to-date swagger.json
    • Take swagger file from blank netbox installation (2.7.10)
    • Patch swagger spec for incorrect definitions / missing parts
  • Higher-level abstraction code to handle polymorphism

@mraerino mraerino requested a review from awlx January 5, 2020 10:08
@kobayashi
Copy link
Contributor

@mraerino Still working for this? Sorry for late but, I am planning to add netbox v2.7 for client.

@kobayashi
Copy link
Contributor

@mraerino Are you still working for this? I would like to add v2.7 supported version.

@stefanmcshane
Copy link

@kobayashi @mraerino What is the progress on the 2.7 update? Can we also have the versioning tags match, or closely match the netbox versions?

@mraerino mraerino force-pushed the refactor/autogeneration branch from cca0a34 to 6ff9f63 Compare March 21, 2020 10:27
@mraerino
Copy link
Collaborator Author

mraerino commented Mar 21, 2020

I did the following to update this PR:

I did not make any changes to the swagger.json which is the main goal here.

If anyone is interested in moving this forward, please try out this branch using this:

go get -u github.com/netbox-community/go-netbox@86b0ffb1e31c476e90023d048a43ae43a794e3b1

if you are using types from the models, you'd want to replace github.com/netbox-community/go-netbox/netbox/models with github.com/netbox-community/go-netbox/models

@awlx
Copy link
Collaborator

awlx commented Oct 2, 2020

I cherry-picked some of the ideas to master. Are we going to keep this open or close for good?

@v0ctor
Copy link
Collaborator

v0ctor commented Feb 24, 2023

Closing, since there is no activity and these changes were added in #143.

@v0ctor v0ctor closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants