Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace "go-swagger" by "oapi-codegen" #161

Closed
wants to merge 8 commits into from

Conversation

v0ctor
Copy link
Collaborator

@v0ctor v0ctor commented Oct 17, 2023

Since version 3.5, Netbox specifies its API with OpenAPI 3. Thus, it is no longer possible to keep this project up to date, as it is generated using go-swagger, a library that doesn't support OpenAPI 3 and has no intention to do so.

This PR replaces go-swagger by oapi-codegen and rebuilds the library for the latest version of Netbox (3.6.3). This change is completely incompatible with previous versions of the library. This is an alternative option to PR #157.

Note that this is a work in progress. I still didn't test the changes.

Any comments, suggestions or corrections are welcome! Furthermore, everyone is invited to participate in the OpenAPI 3 migration discussion.

@v0ctor v0ctor mentioned this pull request Oct 17, 2023
@v0ctor v0ctor force-pushed the feature/oapi-codegen branch from cd281fd to de0b09d Compare October 17, 2023 17:50
@v0ctor v0ctor force-pushed the feature/oapi-codegen branch from de0b09d to cc909b7 Compare October 17, 2023 18:13
@shamil2
Copy link

shamil2 commented Nov 27, 2023

Hello, any update on this PR?

@zyxep
Copy link

zyxep commented Nov 30, 2023

any updates on this one?
the new OAPI specs is kinda blocking me from upgrading my netbox instance :(

@v0ctor
Copy link
Collaborator Author

v0ctor commented Jan 10, 2024

Closing, since "openapi-generation" has been chosen as the final option.

@v0ctor v0ctor closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants