Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dell PowerEdge MX7000 device type #440

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

scotsie
Copy link
Contributor

@scotsie scotsie commented Aug 5, 2021

My first attempt at this but I believe I met all the recommendations and requirements. Open to feedback/criticism so please fire away.

@scotsie scotsie marked this pull request as ready for review August 5, 2021 17:57
scotsie added 4 commits August 5, 2021 14:07
Correcting rack unit height
Removed space from blank line
Fixing trailing space with the required blank line.
Trying the blank line at the end again.
@scotsie
Copy link
Contributor Author

scotsie commented Aug 16, 2021

ok, can I get a sanity check from someone more experienced that me?
The first validation check failed due to missing a trailing blank line it seemed.
I added the blank line but didn't notice an automatic indent. Validation failed due to a space.
Removed the space but validation then failed as it seemed to ignore the empty last line.
Added a new blank line, ensured no spaces and committed. Now validation is failing for blank line 1 > 0.

trying this with just the newline
@scotsie
Copy link
Contributor Author

scotsie commented Aug 16, 2021

ok, can I get a sanity check from someone more experienced that me?
The first validation check failed due to missing a trailing blank line it seemed.
I added the blank line but didn't notice an automatic indent. Validation failed due to a space.
Removed the space but validation then failed as it seemed to ignore the empty last line.
Added a new blank line, ensured no spaces and committed. Now validation is failing for blank line 1 > 0.

ok, maybe I was just being silly... 'new line' doesn't mean empty line, just a carriage return at the last line of code... taking a shot at that and making sure no empty spaces either.

@ryanmerolle
Copy link
Contributor

The power connector type is not valid with regards to our schema that the CI uses found in tests/schema.json

netbox-community/netbox/issues/6883 was only just merged in to netbox core, but now someone needs to update the file I mentioned.

Do you want to take a stab at it? Super simple. You can even add it to this PR if you like.

Add c21/c22 to schema
@scotsie
Copy link
Contributor Author

scotsie commented Aug 23, 2021

Appreciate the feedback, didn't realize that was the validation check that was failing based on the output. Working on adding those 2 entries.

@ryanmerolle ryanmerolle merged commit 485027a into netbox-community:master Aug 25, 2021
@ryanmerolle
Copy link
Contributor

Thanks for the work here!

etherwrangler pushed a commit to etherwrangler/devicetype-library that referenced this pull request Jul 16, 2023
* Adding Dell PowerEdge MX7000 device type
* Add c21/c22 to schema

Co-authored-by: Scott Crace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants