-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Dell PowerEdge MX7000 device type #440
Conversation
Correcting rack unit height
Removed space from blank line
Fixing trailing space with the required blank line.
Trying the blank line at the end again.
ok, can I get a sanity check from someone more experienced that me? |
trying this with just the newline
ok, maybe I was just being silly... 'new line' doesn't mean empty line, just a carriage return at the last line of code... taking a shot at that and making sure no empty spaces either. |
The power connector type is not valid with regards to our schema that the CI uses found in tests/schema.json netbox-community/netbox/issues/6883 was only just merged in to netbox core, but now someone needs to update the file I mentioned. Do you want to take a stab at it? Super simple. You can even add it to this PR if you like. |
Add c21/c22 to schema
Appreciate the feedback, didn't realize that was the validation check that was failing based on the output. Working on adding those 2 entries. |
Thanks for the work here! |
* Adding Dell PowerEdge MX7000 device type * Add c21/c22 to schema Co-authored-by: Scott Crace <[email protected]>
My first attempt at this but I believe I met all the recommendations and requirements. Open to feedback/criticism so please fire away.