Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns-reports is reporting on devices with no interfaces #28

Open
acaronmd opened this issue Apr 5, 2020 · 0 comments
Open

dns-reports is reporting on devices with no interfaces #28

acaronmd opened this issue Apr 5, 2020 · 0 comments

Comments

@acaronmd
Copy link

acaronmd commented Apr 5, 2020

dns-reports checks for dns entries for devices with IPs assigned to an interface. This line filters out devices with no interfaces, but in my case, it still returns devices with no interfaces, because it returns an empty QuerySet
https://github.com/netbox-community/reports/blob/9b4a4fab71c5a10469988f362f410b295b9f317e/reports/ipam-reports/dns-reports.py#L13

I've fixed the issue locally by replacing it with this line.
if not device.interfaces.exists():

http://docs.djangoproject.com/en/dev/ref/models/querysets/#exists

mmahacek pushed a commit to mmahacek/reports that referenced this issue Apr 6, 2020
mmahacek pushed a commit to mmahacek/reports that referenced this issue Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant