Let programs outside librewolf sandbox open new tabs in librewolf #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #4538. |
kmk3
approved these changes
Sep 15, 2021
rusty-snake
approved these changes
Sep 15, 2021
|
I deleted comment. |
|
Merged, thanks. |
Closed
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 11, 2024
It appears that LibreWolf 129 uses `io.gitlab.firefox.*` as the dbus
name.
Commands used to check the dbus name:
$ busctl --user --no-legend | grep -v '^:' | grep librewolf |
sed -E 's/(^[^ ]+\.)[^. ]+ .*/\1/'
io.gitlab.firefox.
Commands used to test dbus communication:
# Open a new browser instance:
$ firejail --name=lwtest --ignore=name --ignore='dbus-user none' \
--dbus-user=filter --dbus-user.own='io.gitlab.firefox.*' \
--private --net=none --ignore=net /usr/bin/librewolf
# In another shell, try to open a new tab:
$ firejail --join=lwtest /usr/bin/librewolf --new-tab about:blank
# Check that the new tab was opened
Related commits:
* c3f2996 ("Let programs outside librewolf sandbox open new tabs in
librewolf (netblue30#4546)", 2021-09-19)
* a8ad9ca ("Update librewolf.profile: use new message bus",
2022-02-03) / PR netblue30#4897
* 4211ee3 ("merges", 2022-02-04)
Fixes netblue30#6413.
Misc: This was noticed on netblue30#6444.
Reported-by: @Lonniebiz
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 13, 2024
It appears that LibreWolf 129 uses `io.gitlab.firefox.*` as the dbus
name.
Commands used to check the dbus name:
$ busctl --user --no-legend | grep -v '^:' | grep librewolf |
sed -E 's/(^[^ ]+\.)[^. ]+ .*/\1/'
io.gitlab.firefox.
Commands used to test dbus communication:
# Open a new browser instance:
$ firejail --name=lwtest --ignore=name --ignore='dbus-user none' \
--dbus-user=filter --dbus-user.own='io.gitlab.firefox.*' \
--private --net=none --ignore=net /usr/bin/librewolf
# In another shell, try to open a new tab:
$ firejail --join=lwtest /usr/bin/librewolf --new-tab about:blank
# Check that the new tab was opened
Related commits:
* c3f2996 ("Let programs outside librewolf sandbox open new tabs in
librewolf (netblue30#4546)", 2021-09-19)
* a8ad9ca ("Update librewolf.profile: use new message bus",
2022-02-03) / PR netblue30#4897
* 4211ee3 ("merges", 2022-02-04)
Fixes netblue30#6413.
Misc: This was noticed on netblue30#6444.
Reported-by: @Lonniebiz
kmk3
added a commit
that referenced
this pull request
Sep 13, 2024
It appears that LibreWolf 129 uses `io.gitlab.firefox.*` as the dbus
name.
Commands used to check the dbus name:
$ busctl --user --no-legend | grep -v '^:' | grep librewolf |
sed -E 's/(^[^ ]+\.)[^. ]+ .*/\1/'
io.gitlab.firefox.
Commands used to test dbus communication:
# Open a new browser instance:
$ firejail --name=lwtest --ignore=name --ignore='dbus-user none' \
--dbus-user=filter --dbus-user.own='io.gitlab.firefox.*' \
--private --net=none --ignore=net /usr/bin/librewolf
# In another shell, try to open a new tab:
$ firejail --join=lwtest /usr/bin/librewolf --new-tab about:blank
# Check that the new tab was opened
Related commits:
* c3f2996 ("Let programs outside librewolf sandbox open new tabs in
librewolf (#4546)", 2021-09-19)
* a8ad9ca ("Update librewolf.profile: use new message bus",
2022-02-03) / PR #4897
* 4211ee3 ("merges", 2022-02-04)
Fixes #6413.
Misc: This was noticed on #6444.
Reported-by: @Lonniebiz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple pull request.