rename noautopulse to keep-config-pulse #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * add the keep-config-pulse option * make noautopulse an alias for keep-config-pulse * deprecate the noautopulse option * misc: fix indentation of --keep-dev-shm on src/firejail/usage.c Even though noautopulse is not intended for hardening, it looks like it is, because it starts with "no", just like no3d, noroot, etc). In fact, it is the only "no" option that differs in such a way. And it has been accidentally misused as such before; see PR netblue30#4269 and commit e4beaea ("drop noautopulse from agetpkg"). So effectively rename it to keep-config-pulse in order to avoid confusion. This is similar to the keep-var-tmp and keep-dev-shm options, which are used to "leave a path alone", just like noautopulse. Note: The changes on this patch are based on the ones from commit 617ff40 ("add --noautopulse arg for complex pulse setups") / PR netblue30#1854. See netblue30#4269 for the discussion.
rusty-snake
reviewed
May 14, 2021
glitsj16
reviewed
May 14, 2021
vermeeren
approved these changes
May 14, 2021
Fred-Barclay
approved these changes
May 14, 2021
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jan 5, 2022
See CONTRIBUTING.md. The changes are based on what was done on commit 5a61202 ("rename noautopulse to keep-config-pulse", 2021-05-13) / PR netblue30#4278. This amends commit bd15e76 ("--noprinter option", 2021-10-20) and commit d9403dc ("small fix", 2021-10-20). Relates to netblue30#4607.
rusty-snake
referenced
this pull request
in ssokolow/nodo
Jan 27, 2022
ssokolow
pushed a commit
to ssokolow/nodo
that referenced
this pull request
Jan 27, 2022
(Thanks to @rusty-snake for pointing out netblue30/firejail#4278)
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jul 9, 2024
This command is deprecated and may be confused for a hardening option. This amends commit 5a61202 ("rename noautopulse to keep-config-pulse", 2021-05-13) / PR netblue30#4278. This is a follow-up to netblue30#6390.
kmk3
added a commit
that referenced
this pull request
Jul 11, 2024
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 10, 2024
Reset the bold right after each command/argument.
Command used to check for issues:
git grep -E ' \\fR' -- src/man/*.in
Related commits:
* e91b9ff ("Deprecate --nodbus option", 2020-04-07) /
PR netblue30#3265
* 5a61202 ("rename noautopulse to keep-config-pulse", 2021-05-13) /
PR netblue30#4278
* d79547c ("docs: warn about limitations of landlock", 2024-03-31) /
PR netblue30#6302
This is a follow-up to netblue30#6451.
Relates to netblue30#6078.
kmk3
added a commit
that referenced
this pull request
Sep 12, 2024
Reset the bold right after each command/argument.
Command used to check for issues:
git grep -E ' \\fR' -- src/man/*.in
Related commits:
* e91b9ff ("Deprecate --nodbus option", 2020-04-07) /
PR #3265
* 5a61202 ("rename noautopulse to keep-config-pulse", 2021-05-13) /
PR #4278
* d79547c ("docs: warn about limitations of landlock", 2024-03-31) /
PR #6302
This is a follow-up to #6451.
Relates to #6078.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Even though noautopulse is not intended for hardening, it looks like it
is, because it starts with "no", just like no3d, noroot, etc). In fact,
it is the only "no" option that differs in such a way.
And it has been accidentally misused as such before; see PR #4269 and
commit e4beaea ("drop noautopulse from agetpkg").
So effectively rename it to keep-config-pulse in order to avoid
confusion. This is similar to the keep-var-tmp and keep-dev-shm
options, which are used to "leave a path alone", just like noautopulse.
Note: The changes on this patch are based on the ones from commit
617ff40 ("add --noautopulse arg for complex pulse setups") / PR #1854.
See #4269 for the discussion.
Cc: @vermeeren (as the author of #1854)