-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/vim: add missing noinput command to syn match #4259
Conversation
Added on commit a90386d ("Map /dev/input with "--private-dev", add "--no-input" option to disable it") / PR netblue30#4209. See also commit 0cee0ba ("Add noinput to all profiles with private-dev") / PR netblue30#4239. Misc: I noticed that it was missing due to the lack of syntax highlighting on etc/profile-m-z/webstorm.profile.
4f028ae
to
22a91ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW: dbus-*
has no highlighting too.
Sorry for the late reply, I've been AFK.
Good catch. This one is more complicated as it has 3 different forms and
The commands/subcommands can be matched basically as is above, but validating grep -E '^(\*|[A-Za-z_-][A-Za-z0-9_-]*(\.[A-Za-z_-][A-Za-z0-9_-]*)*((\.[A-Za-z_-][A-Za-z0-9_-]*)+|\.\*))$' It seems to match the behavior of the function in all the tests that I came up I could also just make the arguments match I think I'll try it in a new PR, but feel free to discuss it here in the |
Added on commit 617ff40 ("add --noautopulse arg for complex pulse setups") / PR netblue30#1854. Misc: I noticed that it was missing when comparing it to contrib/vim/syntax/firejail.vim on commit 22a91ae ("contrib/vim: add missing noinput command to syn match") / PR netblue30#4259.
Added on commit 617ff40 ("add --noautopulse arg for complex pulse setups") / PR netblue30#1854. Note: The template was added after that, on commit cb98aea ("Add profile templates"). Misc: I noticed that it was missing when comparing it to contrib/vim/syntax/firejail.vim on commit 22a91ae ("contrib/vim: add missing noinput command to syn match") / PR netblue30#4259.
All newly added commands/conditions since a1cc4a5 (I found): |
Good catch. Would you mind creating an issue/task for that (and ideally In a similar vein, I plan on moving some scattered ideas from my comments to Additionally, I have some other branches that I'm working on in the meantime, |
Added on commit a90386d ("Map /dev/input with "--private-dev", add
"--no-input" option to disable it") / PR #4209. See also commit
0cee0ba ("Add noinput to all profiles with private-dev") / PR #4239.
Misc: I noticed that it was missing due to the lack of syntax
highlighting on etc/profile-m-z/webstorm.profile.
Cc: @davidebeatrici (as the author of #4209)