Fix Brave's native sandbox #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly I don't believe |
|
|
|
@Vincent43 I've updated the PR, implementing your suggestions. |
|
For me this looks fine now. It would be appreciated if any of the reviewers could merge this after checking the updated commits. TIA. |
|
@glitsj16 looks fine to me however the commits may be cleaned up to not introduce changes that are later reverted. Alternatively the whole thing may be squashed. |
|
@netblue30 Do we need to backport this to the release-0.9.62 branch? |
rusty-snake
pushed a commit
to rusty-snake/firejail
that referenced
this pull request
Dec 21, 2019
* Allow user access to /proc/config.gz * Fix Brave's native sandbox * Move /proc/config.gz to disable-common.inc * Move /proc/config.gz to disable-common.inc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: leave this unmerged until collaborators have had ample opportunity to review.
This is a tentative fix for #2944. The patch enables using
noblacklist /proc/config.gzin/etc/firejail/brave.profile. Momentarily this is only needed for that one profile, so I'm not entirely convinced this is the best way to fix #2914. Thoughts?