Add Microsoft Teams for Linux (Electron) profile #2710
Conversation
etc/teams-for-linux.profile
Outdated
| private-dev | ||
| private-etc fonts,machine-id,localtime,ld.so.cache,ca-certificates,ssl,pki,crypto-policies,resolv.conf | ||
| private-tmp | ||
| disable-mnt |
There was a problem hiding this comment.
Move over private-bin.
There was a problem hiding this comment.
This was the only comment I wasn't sure about what was meant. When you mention move over private-bin, what do you mean? Thanks again for all your help in looking at this.
There was a problem hiding this comment.
This order:
disable-mnt
private-bin
private-cache
private-dev
private-etc
private-tmp
|
Also add |
|
@TheDarkTrumpet any updates on this? 😄 |
|
@Fred-Barclay note his status 😉 : I may be slow to respond. |
|
heh, thanks for the poke on that. Sorry for not responding earlier - starting a new job soon so work has been pretty crazy right now trying to wrap up stuff in current job and prepare for the new one. I have time this weekend to implement the changes and verify. I'll have them pushed by the end of this weekend |
…and definition for the teams-for-linux.local
|
@TheDarkTrumpet Thanks! No rush, just was wondering if there was an update. 😃 Congrats on the new job! @rusty-snake Ah yes, got to remember we have that feature on GitHub now.. |
…again. Also adding disable-exec instead of the noexec /tmp block
|
Alright, I think I got all the changes added minus the "move over private-bin" part. Please let me know if there's anything I missed or anything you suggest I try adding. I'll probably spend some more time adding new profiles for other programs I use as there's a few that could benefit from this. Thanks for putting together this fantastic project. |
https://gist.github.com/SkewedZeppelin/f85777e5094e8ff899d5b7346bda2b8a |
|
Uhh I see @SkewedZeppelin has already posted a patch. |
|
I pushed the changes according to the patch (I didn't apply it directly since some was already added). I'm thinking a bit, and I'm curious if the https://github.com/netblue30/firejail/blob/master/CONTRIBUTING.md can be improved a bit. At first, I could see the improvements from a security standpoint, but quickly became more about making things alphabetical and grouped in certain ways. I definitely understand the desire to keep things clean though. While I feel like I got a decent handle on the desires at this point, it wasn't until the diff popped up that I noticed the alphabetical nature of it all. It probably didn't help I used Discord as a jumping off point for Teams since they're similar in terms of functionality. I do want to help with other profiles, and I want to see others also help with the profiles. I think updating the Contributing that kinda spells out at least the formatting desires would be great, then the bulk of the pull requests could be better served in adding and tightening security concerns. |
|
This looks fine now. As for the format and new contributor issues, they are very real. |
|
That profile.template is amazingly helpful. Wish I found that earlier. I found another issue (#2730 ) that I commented on as well. Going to subscribe to both issues. The tl;dr for pretty much anything I can recommend is the Table of Contents, or the jumping off point, should be bubbled up to the most likely place people would start looking. Contrib, or readme. I'll mention the same thing in #2729 to keep issue discussion with issues. |
No description provided.