Check if the cancel function was set before using it #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases an IDP device flow expiration time might be shorter than 90s we should check if the cancel context was set before using it We will need a follow-up to identify and document the IDP with lower defaults. fixes #890
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
in some cases an IDP device flow expiration time might be shorter than 90s we should check if the cancel context was set before using it We will need a follow-up to identify and document the IDP with lower defaults. fixes netbirdio#890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
in some cases an IDP device flow expiration time might be shorter than 90s we should check if the cancel context was set before using it
We will need a follow-up to identify and document the IDP with lower defaults.
Issue ticket number and link
fixes #890
Checklist